-
Notifications
You must be signed in to change notification settings - Fork 21
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-transition
base: 1d08a765232c701d0bc5ec124f12998300af30dc
head repository: puppetlabs/puppetlabs-transition
compare: 0.1.0
- 18 commits
- 7 files changed
- 2 contributors
Commits on Nov 7, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 1c3f159 - Browse repository at this point
Copy the full SHA 1c3f159View commit details -
Has the initial property and parameters, still needs validation filled in and a provider created.
Configuration menu - View commit details
-
Copy full SHA for e943d72 - Browse repository at this point
Copy the full SHA e943d72View commit details -
Change property attrib from resource to attributes
The resource needs at least one property. Previously it was resource, but from a checking-state perspective it makes more sense to say we will be checking and changing the attributes than to say we will be changing the resource.
Configuration menu - View commit details
-
Copy full SHA for be505c4 - Browse repository at this point
Copy the full SHA be505c4View commit details -
Switch property from attributes to enable
This way resource, attributes and prior_to can be simple parameters and the new enable property can be dedicated to determining insync status.
Configuration menu - View commit details
-
Copy full SHA for 02e6bfd - Browse repository at this point
Copy the full SHA 02e6bfdView commit details -
Wire up enable property in the type, stub provider
This commit introduces what should be a functional type, and lays out what methods the provider needs to implement to achieve the desired functionality.
Configuration menu - View commit details
-
Copy full SHA for 16ef6ae - Browse repository at this point
Copy the full SHA 16ef6aeView commit details
Commits on Nov 8, 2014
-
Add required param validation, stub provider
Start work on the provider and add validation method to the type to require the required parameters.
Configuration menu - View commit details
-
Copy full SHA for 2d08f93 - Browse repository at this point
Copy the full SHA 2d08f93View commit details
Commits on Nov 10, 2014
-
Still a lot of work to do to clean it up and make it log sanely, but this appears to be a working core framework for the type/provider.
Configuration menu - View commit details
-
Copy full SHA for 6624d99 - Browse repository at this point
Copy the full SHA 6624d99View commit details
Commits on Nov 11, 2014
-
This ensures that the resource will have a before dependency on any prior_to reference, as well as the resource itself.
Configuration menu - View commit details
-
Copy full SHA for 7d66dca - Browse repository at this point
Copy the full SHA 7d66dcaView commit details -
Omit relationships from transition resource
We don't need the transitional state to have require, notify, before, etc. It is by nature a one-off transition.
Configuration menu - View commit details
-
Copy full SHA for 8231be2 - Browse repository at this point
Copy the full SHA 8231be2View commit details -
Better incorporate the fact that the enable "property" is what triggers entering or not entering a transition state into the log messages. We shouldn't just say the enable property is changing; we should, if it changes, say what the changes are.
Configuration menu - View commit details
-
Copy full SHA for 9ff8d11 - Browse repository at this point
Copy the full SHA 9ff8d11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97553b6 - Browse repository at this point
Copy the full SHA 97553b6View commit details
Commits on Nov 18, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 8d8d000 - Browse repository at this point
Copy the full SHA 8d8d000View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c0b672 - Browse repository at this point
Copy the full SHA 7c0b672View commit details -
Configuration menu - View commit details
-
Copy full SHA for 994fd66 - Browse repository at this point
Copy the full SHA 994fd66View commit details -
Add a basic CHANGELOG, add the LICENSE file, and make metadata match what is generated by the PMT
Morgan Haskel committedNov 18, 2014 Configuration menu - View commit details
-
Copy full SHA for 2f8c3ec - Browse repository at this point
Copy the full SHA 2f8c3ecView commit details -
Merge pull request #1 from puppetlabs/0.1.0-prep
Prep for 0.1.0 release
Configuration menu - View commit details
-
Copy full SHA for 7cb6a98 - Browse repository at this point
Copy the full SHA 7cb6a98View commit details -
Morgan Haskel committed
Nov 18, 2014 Configuration menu - View commit details
-
Copy full SHA for fef1136 - Browse repository at this point
Copy the full SHA fef1136View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ef9659 - Browse repository at this point
Copy the full SHA 9ef9659View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1d08a765232c701d0bc5ec124f12998300af30dc...0.1.0