Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-transition
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1d08a765232c701d0bc5ec124f12998300af30dc
Choose a base ref
...
head repository: puppetlabs/puppetlabs-transition
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.0
Choose a head ref
  • 18 commits
  • 7 files changed
  • 2 contributors

Commits on Nov 7, 2014

  1. Fix heinous logic error

    reidmv committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    1c3f159 View commit details
    Browse the repository at this point in the history
  2. Add stub type definition

    Has the initial property and parameters, still needs validation filled
    in and a provider created.
    reidmv committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    e943d72 View commit details
    Browse the repository at this point in the history
  3. Change property attrib from resource to attributes

    The resource needs at least one property. Previously it was resource,
    but from a checking-state perspective it makes more sense to say we will
    be checking and changing the attributes than to say we will be changing
    the resource.
    reidmv committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    be505c4 View commit details
    Browse the repository at this point in the history
  4. Switch property from attributes to enable

    This way resource, attributes and prior_to can be simple parameters and
    the new enable property can be dedicated to determining insync status.
    reidmv committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    02e6bfd View commit details
    Browse the repository at this point in the history
  5. Wire up enable property in the type, stub provider

    This commit introduces what should be a functional type, and lays out
    what methods the provider needs to implement to achieve the desired
    functionality.
    reidmv committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    16ef6ae View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2014

  1. Add required param validation, stub provider

    Start work on the provider and add validation method to the type to
    require the required parameters.
    reidmv committed Nov 8, 2014
    Configuration menu
    Copy the full SHA
    2d08f93 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2014

  1. Commit initial working stub

    Still a lot of work to do to clean it up and make it log sanely, but
    this appears to be a working core framework for the type/provider.
    reidmv committed Nov 10, 2014
    Configuration menu
    Copy the full SHA
    6624d99 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2014

  1. Add autobefore to the type

    This ensures that the resource will have a before dependency on any
    prior_to reference, as well as the resource itself.
    reidmv committed Nov 11, 2014
    Configuration menu
    Copy the full SHA
    7d66dca View commit details
    Browse the repository at this point in the history
  2. Omit relationships from transition resource

    We don't need the transitional state to have require, notify, before,
    etc. It is by nature a one-off transition.
    reidmv committed Nov 11, 2014
    Configuration menu
    Copy the full SHA
    8231be2 View commit details
    Browse the repository at this point in the history
  3. Add better event logging

    Better incorporate the fact that the enable "property" is what triggers
    entering or not entering a transition state into the log messages. We
    shouldn't just say the enable property is changing; we should, if it
    changes, say what the changes are.
    reidmv committed Nov 11, 2014
    Configuration menu
    Copy the full SHA
    9ff8d11 View commit details
    Browse the repository at this point in the history
  4. Further improve error logging

    reidmv committed Nov 11, 2014
    Configuration menu
    Copy the full SHA
    97553b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2014

  1. Configuration menu
    Copy the full SHA
    8d8d000 View commit details
    Browse the repository at this point in the history
  2. Add metadata.json file

    Prep for publication
    reidmv committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    7c0b672 View commit details
    Browse the repository at this point in the history
  3. Fix typo

    reidmv committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    994fd66 View commit details
    Browse the repository at this point in the history
  4. Prep for 0.1.0 release

    Add a basic CHANGELOG, add the LICENSE file, and make metadata match
    what is generated by the PMT
    Morgan Haskel committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    2f8c3ec View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1 from puppetlabs/0.1.0-prep

    Prep for 0.1.0 release
    reidmv committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    7cb6a98 View commit details
    Browse the repository at this point in the history
  6. Fix issues URL

    Morgan Haskel committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    fef1136 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2 from puppetlabs/fix_issues_url

    Fix issues URL
    reidmv committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    9ef9659 View commit details
    Browse the repository at this point in the history
Loading