Add validation to transition type

[elyscape]

This adds validations to ensure that:

1. The value of resource is either a valid resource reference or a string that can be converted to a valid resource reference.
2. The resource specified in resource exists in the catalog.
3. The value of attributes is a hash.
4. All the specified attributes are valid parameters for the specified resource.
5. The values of prior_to are valid resource references or strings that can be converted to valid resource references.
6. All resources specified in prior_to exist in the catalog.

Additionally, it adds munging to resolve the values of resource and prior_to into their catalog representations and removes the now-redundant resource resolution from the provider.

[elyscape]

Any update on this?

[elyscape]

Pinging @hunner, @reidmv.

[reidmv]

@elyscape whoa, thanks for doing this! This didn't get on my radar. Sorry for the radio silence on the PR.

I really like the general form of this. It looks like there are two problems that need to be resolved before it can be merged. I'll comment inline on where I'm having problems running the new code.

[reidmv]

Running under Puppet 4.3.2.

Manifest:

file { '/tmp/test':
  ensure  => file,
  content => 'enabled=1',
  before  => Notify['test'],
}

notify { 'test': }

transition { 'stop myapp service':
  resource   => File['/tmp/test'],
  attributes => { ensure => absent },
  prior_to   => Notify['test']
}

Error:

[reidmv@halcyon:~/src/puppetlabs-transition/] % puppet apply test2.pp
Notice: Compiled catalog for halcyon.corp.puppetlabs.net in environment production in 0.05 seconds
Error: Parameter attributes failed on Transition[stop myapp service]: Validate method failed for class attributes: undefined method `valid_parameter?' for #<Puppet::Type::File:0x007faca4851788> at /Users/reidmv/src/puppetlabs-transition/test2.pp:9

[elyscape]

Found the bug.

[elyscape]

@reidmv Since this pull request is reworking the validation, should I also remove the type-wide validate method, which only ensures that resource, attributes, and prior_to are provided, and just put isrequired on those attributes? Is there a reason you went that route instead of using isrequired?

[elyscape]

Okay, validation and munging moved to the pre_run_check method so that we can guarantee that resources will be in the catalog if they actually exist. Please weigh in on whether I should add isrequired to the resource, attributes, and prior_to attributes.

[reidmv]

@elyscape Thank you, this looks great! I'm 👍 to merge.

Regarding isrequired, I don't remember why I chose to do a global validate. I don't think it was functional, it would be fine to switch to just specifying isrequired on those properties/parameters. If you'd like to open a second PR on that I'll merge it.

[reidmv]

@hunner what are next steps for cutting a Forge release, given that transition is in the puppetlabs namespace?