Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't 'su' if passed user is current user #105

Merged
merged 1 commit into from
Jan 24, 2014
Merged

Conversation

mcanevet
Copy link

No description provided.

@sodabrew
Copy link

sodabrew commented Dec 3, 2013

Facter isn't used anywhere else in the vcsrepo module, is this introducing an undesirable dependency?

@apenney
Copy link

apenney commented Dec 3, 2013

I don't think so, I mean Puppet without Facter is already broken and id has been a fact since the dawn of Facter, so this is fine (as far as I'm concerned).

@sodabrew
Copy link

sodabrew commented Dec 3, 2013

Sounds reasonable to merge then.

@mcanevet
Copy link
Author

@apenney could you merge this one please ?

apenney pushed a commit that referenced this pull request Jan 24, 2014
Don't 'su' if passed user is current user
@apenney apenney merged commit 50079b5 into puppetlabs:master Jan 24, 2014
@apenney
Copy link

apenney commented Jan 24, 2014

I can and will!

@mcanevet mcanevet deleted the no_su branch January 24, 2014 14:03
cegeka-jenkins pushed a commit to cegeka/puppet-vcsrepo that referenced this pull request Jan 3, 2018
Don't 'su' if passed user is current user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants