Bug fix: Git provider on_branch? retains trailing newline

[mikegerwitz]

I submitted a patch yesterday for using --abbrev-ref for on_branch?; unfortunately, there is a trailing newline, which causes problems when the repository already exists:

Error: /Stage[main]//Vcsrepo[...]: Could not evaluate: Execution of '/usr/local/bin/git rev-parse origin/master
' returned 128: fatal: ambiguous argument 'origin/master
': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
origin/master

[mikegerwitz]

I'm wholly inexperienced with Ruby, so if there's a better way of doing this than strip (which on_branch? was doing originally), feel free to say so.

[sodabrew]

Does on_branch? return something besides a boolean? Typical Ruby style would be a method ending in ? returns true or false.

[sodabrew]

Oh, on_branch? was pre-existing, let's leave it as is. Looking around, the more common pattern in this file is at_path { git_with_identify(stuff).chomp } - could you switch to that instead? Please also change from if branch == '' to 'if !branch`. Thanks for working on this!

I see your python roots :) Instead of:
return get_revision("#{@resource.value(:remote)}/%s" % branch)
Ruby-ish consistency would be:
return get_revision("#{@resource.value(:remote)}/#{branch}")

[mikegerwitz]

Thanks for your reply, sodabrew; I made the chomp change.

I see your python roots :)

Actually, no Python here---that wasn't my line, but I did make the formatting changes that you requested.

[sodabrew]

nit: chomp inside the brackets

[sodabrew]

Thanks @mikegerwitz!

[sodabrew]

Nice test for the newline!

[mikegerwitz]

Heh, whoops---thanks; corrected.

[sodabrew]

One final request, could you use 'git rebase -i master' to squash the three commits together?