Add acceptance tests for git protocols using clone #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git_clone_protocols_spec.rb will be used to enumerate over the
available protocols for git to use to clone to disk. Support
key files are also included for https/ssl use.
Protocols tested
* file protocol (raw filepath)
* file protocol (file://)
* git protocol (git://)
* http protocol (http://)
* https protocol (https://)
* ssh protocol (ssh://user@host)
TODO: Currently, the ssl cert is not added to the CA on the host.
This causes the git clone to fail because the cert is not trusted
and the client does not proceed with a non-trusted ssl connection.
| EOS | ||
|
|
||
| # Run it twice and test for idempotency | ||
| on(host,apply_manifest(pp, :catch_failures => true)) |
There was a problem hiding this comment.
These should be apply_manifest_on(host, pp, :catch_failures => true)
There was a problem hiding this comment.
Or if there is only a default host, apply_manifest(pp, :catch_failures => true)
| host.execute('ssh-keygen -q -t rsa -f /root/.ssh/id_rsa -N ""') | ||
|
|
||
| # copy public key to authorized_keys | ||
| host.execute('cat /root/.ssh/id_rsa.pub >> /home/testuser/.ssh/authorized_keys') |
There was a problem hiding this comment.
Is this different than on(host, ...)? If we only have one default host, you can use shell()
apenney
pushed a commit
that referenced
this pull request
May 19, 2014
Add acceptance tests for git protocols using clone
cegeka-jenkins
pushed a commit
to cegeka/puppet-vcsrepo
that referenced
this pull request
Jan 3, 2018
…ance_tests Add acceptance tests for git protocols using clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git_clone_protocols_spec.rb will be used to enumerate over the
available protocols for git to use to clone to disk. Support
key files are also included for https/ssl use.
Protocols tested
TODO: Currently, the ssl cert is not added to the CA on the host.
This causes the git clone to fail because the cert is not trusted
and the client does not proceed with a non-trusted ssl connection.