Update specs and fix FM-1361 #145
Conversation
hunner
commented
May 21, 2014
hunner
commented
- Add install.rb for pre-suite
- Add catches for failures/changes to manifest application
- Correct root ssh key copying
- Add sleeps for killing processes releasing ports
- Fix FM-1361
| @@ -22,7 +22,8 @@ | |||
| } | |||
| EOS | |||
|
|
|||
| apply_manifest_on(host, pp) | |||
| apply_manifest_on(host, pp, :catch_failures => true) | |||
There was a problem hiding this comment.
This is a negative test. The manifest should fail to create the repo when a revision is specified in conjunction with the bare command. Please change to
apply_manifest_on(host, pp, :expect_failures => true)
There was a problem hiding this comment.
Well it doesn't fail then either.
The first run gives: Notice: /Stage[main]/Main/Vcsrepo[/tmp/vcsrepo.a4VbnV/testrepo_bare.git]/ensure: created
The second run gives: Error: /Stage[main]/Main/Vcsrepo[/tmp/vcsrepo.a4VbnV/testrepo_bare.git]: Could not evaluate: Execution of '/usr/bin/git config remote.origin.url' returned 1:
So is the provider supposed to fail to create a repo, or supposed to ignore the revision on bare repos?
There was a problem hiding this comment.
The expectation is that the provider should fail to create a repo because these parameters are incompatible.
Add the expect_failures. I will open a ticket that we should not be failing silently.
- Add install.rb for pre-suite - Add catches for failures/changes to manifest application - Correct root ssh key copying - Add sleeps for killing processes releasing ports - Fix FM-1361
Update specs and fix FM-1361
Update specs and fix FM-1361
