Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with node changing every checkin #181

Merged
merged 1 commit into from
Jun 30, 2014
Merged

Fix issue with node changing every checkin #181

merged 1 commit into from
Jun 30, 2014

Conversation

jbussdieker
Copy link

git-rev-parse will give you the hash of the tag object itself rather than the commit it points to by default. Using tag^0 will return the actual commit.

$ git rev-parse 0.0.152
238cc0ee29ada7069778d3711084b81b8a0ffbaa
$ git rev-parse 0.0.152^0
e6911e9ee1d589b8192ec2f6bbb6edc396ad5c2b
$ git rev-parse 0.0.152^{commit}
e6911e9ee1d589b8192ec2f6bbb6edc396ad5c2b

@sodabrew
Copy link

Awesome fix! Could you add a comment just above this line? The text of the PR is great. Basically just explain the ^0 thing to the next person who reads this line of code.

@jbussdieker
Copy link
Author

Thanks! The pull request now includes a comment along with the fix.

@sodabrew
Copy link

Looks good - please squash the commits together and I'll merge today!

@jbussdieker
Copy link
Author

Squashed!

sodabrew added a commit that referenced this pull request Jun 30, 2014
…eckin

Fix issue with node changing every checkin
@sodabrew sodabrew merged commit 3109167 into puppetlabs:master Jun 30, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-vcsrepo that referenced this pull request Jan 3, 2018
…e_every_checkin

Fix issue with node changing every checkin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants