Handle both Array/Enumerable and String values for excludes parameter #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodabrew
force-pushed
the
excludes_string
branch
from
fa31cf8
to
20fc353
Compare
Thanks to @revhazroot for identifying the problem that excludes with a string or single-element array fails on Ruby >= 1.9.
sodabrew
force-pushed
the
excludes_string
branch
from
20fc353
to
0e7c0b0
Compare
sodabrew
added a commit
that referenced
this pull request
Sep 18, 2014
Handle both Array/Enumerable and String values for excludes parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #205 that can handle Array/Enumerable and String in a general way.