Autorequire Package['mercurial']

[mpdude]

Along the lines of 2b19075, if the
Mercurial package is being managed, it stands to reason that the Mercurial
package should be installed before trying to potentially manage Mercurial
repositories using vcsrepo resources.

This commit adds an autorequire to the vcsrepo type that reflects the
above premise.

[DavidS]

Is the mercurial package called 'mercurial' on all platforms? I guess we're not worse off, if it doesn't...

[DavidS]

Thinking more about this, I realize that this is very suboptimal in general, as the "real" requirements are provider dependent, something that is usually hard, but in vcsrepo's case there should always be a provider available on the master. Would you mind having a look into that?

[mpdude]

Sorry, I don't understand what you're talking about... :-(

[DavidS]

vcsrepo instances managing a git resource should not autorequire mercurial, and vcsrepo instances managing mercurial repos should not autorequire git.

[DavidS]

merged. It is a net win after all. Thanks for your patience!

[igalic]

can't we autorequire stuff in the provider?

[DavidS]

I wouldn't know how. But I also have not looked into it in-depth.

Maybe something like Package <|title=='git'|> -> Vcsrepo <| provider == 'git' |> ? this could then also access params fwiw.

[igalic]

and where would that go? init.pp?

[DavidS]

that is another difficult question.