Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature 'depth' and parameter 'trust_server_cert' to svn #269

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

monai
Copy link

@monai monai commented Sep 10, 2015

No description provided.

@monai
Copy link
Author

monai commented Sep 10, 2015

Contribution guidelines state that commits should be done using unix line endings, however README.markdown was committed previously with mixed line endings.

@bmjen
Copy link

bmjen commented Sep 11, 2015

Thanks @monai ! Can you please add a test for the new param as well as squash the commits?

@monai
Copy link
Author

monai commented Sep 12, 2015

Ok, I will do it next week.

added param trust server cert

updated depth feature

updated README.markdown

trust_server_cert is not feature

trust_server_cert default value should be false

add test for depth and trust_server_cert
@monai
Copy link
Author

monai commented Sep 14, 2015

Added tests and squashed commits. Please review.

@bmjen
Copy link

bmjen commented Sep 14, 2015

Thanks @monai !

bmjen added a commit that referenced this pull request Sep 14, 2015
Add feature 'depth' and parameter 'trust_server_cert' to svn
@bmjen bmjen merged commit f0d087a into puppetlabs:master Sep 14, 2015
@steventwheeler
Copy link

steventwheeler commented May 5, 2016

@bmjen Any word on when this will be available on puppet forge? I would love to make use of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants