Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror option for git cloning #282

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Add mirror option for git cloning #282

merged 1 commit into from
Feb 10, 2016

Conversation

Strech
Copy link

@Strech Strech commented Dec 22, 2015

Example:

vcsrepo { '/path/to/repo':
  ensure   => mirror,
  provider => git,
  source   => 'git://example.com/repo.git',
}

@sodabrew
Copy link

This looks good, and thank you very much for writing both unit tests and README text! Past PRs to provide mirror support were #233 and #267 (links for "SEO" not because you need to pull older code from them.

Nit pick: could you avoid changing so much whitespace in the README? It would be OK to have a whitespace-only commit to correct the whitespace before adding your new section, but having it mixed in makes a harder to read diff.

@sodabrew
Copy link

As for behavior of the mirror, should it behave like "latest" and always fetch the remote on every puppet run?

@Strech
Copy link
Author

Strech commented Dec 22, 2015

As for behavior of the mirror, should it behave like "latest" and always fetch the remote on every puppet run?

Nope, mirror is mostly like bare, it will copy everything as bare do, but plus refs
http://stackoverflow.com/questions/3959924/whats-the-difference-between-git-clone-mirror-and-git-clone-bare

Example:

vcsrepo { '/path/to/repo':
  ensure   => mirror,
  provider => git,
  source   => 'git://example.com/repo.git',
}
@Strech
Copy link
Author

Strech commented Dec 22, 2015

@sodabrew I reduce changes in README (sorry for massive whitespace cleanup 😿 )

@Strech
Copy link
Author

Strech commented Jan 5, 2016

@sodabrew Hi, can you have a look at this PR? Is everything ok?

@bmjen
Copy link

bmjen commented Feb 10, 2016

This looks good @Strech ! Thanks for the contribution!

bmjen added a commit that referenced this pull request Feb 10, 2016
Add mirror option for git cloning
@bmjen bmjen merged commit 818734c into puppetlabs:master Feb 10, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-vcsrepo that referenced this pull request Jan 3, 2018
Add mirror option for git cloning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants