[MODULES-3998] Fix to GIT and SVN providers to support older versions of git and svn #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param not supported. Update SVN provider to remove Includes option support from SVN versions < 1.7 and update tests and README to reflect this.
|
ping @squarebracket for a cursory look at the svn changes. |
|
This LGTM. |
|
Dang it! I'm on vacation this week and wasn't able to get a comment in before merge. There original code I wrote didn't use |
cegeka-jenkins
pushed a commit
to cegeka/puppet-vcsrepo
that referenced
this pull request
Jan 3, 2018
[MODULES-3998] Fix to GIT and SVN providers to support older versions of git and svn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to git provider on older git versions where git config --local param not supported. Update SVN provider to remove Includes option support from SVN versions < 1.7 and update tests and README to reflect this.
These issues were picked up on RHEL6 based distros as they use older versions of git and svn.