Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-5889) Added trust_server_cert support to Git provider #360

Merged
merged 2 commits into from
Nov 21, 2017

Conversation

eputnam
Copy link

@eputnam eputnam commented Nov 16, 2017

closes #359

  • Added trust_server_cert support to Git provider
  • Checking for Git version now, the -c parameter wasn't always available
  • Moved the trust_server_cert part to git_with_identity, so it works for cloning, fetching, etc.
  • Updated the README.
  • Changed vcsrepo_git_ver regex to use %r{...}
  • Using git('--version') now, removed Git version fact.

Added trust_server_cert support to Git provider

Checking for Git version now, the -c parameter wasn't always available

Moved the trust_server_cert part to git_with_identity, so it works for cloning, fetching, etc.

Updated the README.

Changed vcsrepo_git_ver regex to use %r{...}

Using git('--version') now, removed Git version fact.
@eputnam
Copy link
Author

eputnam commented Nov 16, 2017

it just occurred to me that this module doesn't support windows. i guess compatibility doesn't hurt anything.

@eputnam eputnam closed this Nov 16, 2017
@eputnam eputnam reopened this Nov 16, 2017
@eputnam eputnam merged commit 818ad33 into puppetlabs:master Nov 21, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-vcsrepo that referenced this pull request Jan 3, 2018
(MODULES-5889) Added trust_server_cert support to Git provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants