Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FM-6957] Removing unsupported OS from Vcsrepo #378

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan
Copy link
Member Author

@@ -5,7 +5,6 @@
describe 'subversion :includes tests on SVN version >= 1.7', unless: ( # rubocop:disable RSpec/MultipleDescribes : The
# test's on this page must be kept seperate as they are for different operating systems.
(fact('osfamily') == 'RedHat' && fact('operatingsystemmajrelease') =~ %r{^(5|6)$}) ||
(fact('osfamily') == 'Debian' && fact('operatingsystemmajrelease') =~ %r{^(6|7|10\.04|12\.04)$}) ||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've removed all versions here instead of just 6 & 7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 12 and 10 are unsupported.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, yep. You're right.

@HelenCampbell HelenCampbell merged commit 9404d68 into puppetlabs:master Jun 4, 2018
@pmcmaw pmcmaw added the bugfix label Sep 20, 2018
@david22swan david22swan deleted the FM-6957 branch January 7, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants