Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FM-8234) Port to Litmus #429

Merged
merged 1 commit into from
Nov 12, 2019
Merged

(FM-8234) Port to Litmus #429

merged 1 commit into from
Nov 12, 2019

Conversation

sheenaajay
Copy link

@sheenaajay sheenaajay commented Oct 15, 2019 •
edited
Loading

Request for a review

Following changes are made to the module

  1. Ported to litmus
  2. Removed test which is not valid since we use the latest svn for testing.
  3. sles platform was not tested on jenkins. Added more platforms through litmus
    4.Added centos8
    5.Updated metadata.json for centos8 and Debian 10
    Release check ran clean on all OS
    Screen Shot 2019-11-12 at 15 49 45

Screen Shot 2019-11-12 at 16 11 41
Screen Shot 2019-11-12 at 23 48 25

@sheenaajay sheenaajay force-pushed the litmusconvert branch 2 times, most recently from 6a339ff to 4919bc1 Compare October 15, 2019 10:28
@sheenaajay sheenaajay requested a review from a team as a code owner October 15, 2019 10:28
@sheenaajay sheenaajay force-pushed the litmusconvert branch 8 times, most recently from d7dbdc5 to 3f54bd1 Compare October 21, 2019 08:18
@sheenaajay sheenaajay force-pushed the litmusconvert branch 2 times, most recently from 8ba519b to 3024307 Compare November 11, 2019 16:43
@lionce
Copy link

lionce commented Nov 12, 2019

close and reopen to rerun travis. It seems to be stuck with loading status

@lionce lionce closed this Nov 12, 2019
@lionce lionce reopened this Nov 12, 2019
@lionce
Copy link

lionce commented Nov 12, 2019

Pipelines still not working -> throwing Timeout error

lionce
lionce reviewed Nov 12, 2019
View reviewed changes
distelli-manifest.yml Outdated
- bundle exec rake litmus:tear_down
CommitData:
- RepoType: Git
- RepoPath: .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor change: new line please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lionce done added new line.
Waiting for the travis run

@sheenaajay sheenaajay force-pushed the litmusconvert branch 2 times, most recently from 4c89d52 to b6aa7d0 Compare November 12, 2019 15:50
@sanfrancrisko sanfrancrisko merged commit d2117f0 into puppetlabs:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

@lionce lionce lionce left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheenaajay @lionce @sanfrancrisko