Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not chown excluded files #432

Merged

Conversation

jfroche
Copy link

@jfroche jfroche commented Nov 8, 2019

When using puppetlabs-vcsrepo with the owner parameter (or
with the group parameter), the entire git repository is chowned
recursively on every update.

This chown can be very long if there are a lot of files in the
repository destination path. This commit excludes the files defined in
the excludes parameter in the chown.

refs https://tickets.puppetlabs.com/browse/MODULES-5922

@jfroche jfroche requested a review from a team as a code owner November 8, 2019 16:32
@jfroche jfroche force-pushed the feature/limit-recursive-chown branch 8 times, most recently from cf047b9 to 61eb226 Compare November 8, 2019 23:14
@florindragos
Copy link

Hey @jfroche
Thanks for you contribution.
Could you please rebase as there has been a change that will allow travis to run acceptance tests on this PR.

When using puppetlabs-vcsrepo with the owner parameter (or
with the group parameter), the entire git repository is chowned
recursively on every update.

This chown can be very long if there are a lot of files in the
repository destination path. This commit excludes the files defined in
the `excludes` parameter in the chown.

refs https://tickets.puppetlabs.com/browse/MODULES-5922
@jfroche jfroche force-pushed the feature/limit-recursive-chown branch from 61eb226 to 429c715 Compare November 26, 2019 10:47
@florindragos florindragos merged commit 7e57f4e into puppetlabs:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants