prevent ANSI color escape sequences from messing up git output #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
no-color
branch
2 times, most recently
from
4ca52f5
to
edf3555
Compare
|
I can't figure out why 0df26c5 and edf3555 caused this test failure: https://travis-ci.org/github/puppetlabs/puppetlabs-vcsrepo/jobs/688290244#L747 But that change was just a bonus, not actually affecting me like the branch color bug, so I'm removing it. |
If git config color.ui is set to "always", then you get ANSI escape codes in the git output, which messes up comparisons. This commit ensures that there are no colors in the output, so you get plain text as expected.
|
That latest build failure is because of timeouts. 🤷 |
|
Thank you @kenyon for submitting the PR. WIll be looking into the timeout issue and have seen the same problem on master branch too. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the git config
color.uiis set to "always", then you get ANSI escape codes in the git output, which messes up comparisons, and results in errors on puppet agent runs. This pull request prevents color in the output.