(GH-552) Fix home directory evaluation #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
GH-552-home_directory_evaluation_fix
branch
from
2c6a035
to
eb4d3ac
Compare
Prior to this commit the module would fail when executed under the context of systemd. This was because Dir.home tries to expand `~` when no UID is passed. However the HOME environment variable is not available when the agent is executed by systemd resulting in the following error: `Could not evaluate: couldn't find login name -- expanding ~` This commit fixes this by reverting to using Etc.getpwuid so that we can retrieve the home dir from the uid of the current process. For consistency, retrieval of home dirs for a given user has also been changed to use Etc.getpwnam.
chelnak
force-pushed
the
GH-552-home_directory_evaluation_fix
branch
from
eb4d3ac
to
28c8a65
Compare
david22swan
approved these changes
Jun 29, 2022
jameslikeslinux
added a commit
to jameslikeslinux/puppet-nest
that referenced
this pull request
Nov 14, 2022
vcsrepo doesn't officially support Windows, but I make it work on Cygwin with a series of wrappers and hacks. puppetlabs/puppetlabs-vcsrepo#553 changes the way home directories are evaluated and breaks on Windows as described at puppetlabs/puppetlabs-vcsrepo#559.
elfranne
added a commit
to elfranne/puppetlabs-vcsrepo
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the module would fail when executed under the context of systemd.
This was because Dir.home tries to expand
~when no UID is passed.However the HOME environment variable is not available when the agent is executed by systemd resulting in the following error:
Could not evaluate: couldn't find login name -- expanding ~This commit fixes this by reverting to using Etc.getpwuid so that we can retrieve the home dir from the uid of the current process.
For consistency, retrieval of home dirs for a given user has also been changed to use Etc.getpwnam.
Fixes #552