support umask for git repos (try 2) #574
Merged
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning a repo, it can be useful to have shared access such that other members of the cloning user's group are able to manage the repo as well. This requires two components: 1. The setgid bit to be set on directories; this can be accomplished by puppet code which creates the repo directory before calling vcsrepo. 2. A umask that allows group writeability to be used during the clone. This patch implements the second component. Note that for git, specifically, there is a core.sharedRepository option, but this only seems to be respected on 'git init', not 'git clone'. By default, git will respect the umask anyhow. I do not have ready access to the other version control systems, so I only implemented this for git, but using a umask is likely portable to other version control systems as well. For the umask rspec test, documentation is here: https://serverspec.org/resource_types.html#file Despite the documentation saying that this "supports 3 and 4 number octet matching", the backend implementation is finnicky. https://github.com/mizzy/specinfra/blob/6e4460cbc46033add002d41266719bf157dbed63/lib/specinfra/command/base/file.rb#L55 This shells out to the stat and grep commands, and the specified stat output format results in a representation that is not zero-padded.
|
Updated to fix the rubocop style check failure. -Corey |
|
Thank you @bugfood, and again, apologies for any inconvenience! |
jordanbreen28
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
@bugfood as suspected all tests are now passing :-)
Happy to merge this change now - thanks again for your work on this one!
|
Nice, thank you. I'm glad we can get this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-attempt of: #541
I can't re-open that PR (see: #541 (comment)).
@jordanbreen28 can you please either check this one or re-open the original PR, if possible now?
Differences from the last revision of the original PR are:
Thanks,
Corey