Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back GIT_SSH support for old git versions #582

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

vStone
Copy link

@vStone vStone commented Dec 15, 2022

Older versions (<2.3) do not support GIT_SSH_COMMAND yet. Fall back to GIT_SSH with a wrapper script.

Fixes MODULES-11111

vcsrepo : identity doesn't work on EL7

@vStone vStone requested a review from a team as a code owner December 15, 2022 15:19
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2022

CLA assistant check
All committers have signed the CLA.

Older versions (<2.3) do not support GIT_SSH_COMMAND yet.
Fall back to GIT_SSH with a wrapper script.
@vStone
Copy link
Author

vStone commented Dec 15, 2022

Sorry for the force commit spam. needed to do some cleaning up

Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit c8b1fe6 into puppetlabs:main Jan 9, 2023
@nbarrientos nbarrientos mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants