Add timeout to ssh connections #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r any other remote connection issues) from blocking the Puppet run
|
👍 SSH uses the system default TCP timeout unless this is specified, and that's often quite a few minutes. |
|
The overall problem is worst that that. Setting a time to connect only solves part of it. It's still possible for Puppet to hang for hours (yes hours) waiting for git to do something. |
|
Could you rebase your commit to current master? I'd like to see tests run. |
sodabrew
added a commit
that referenced
this pull request
Jul 13, 2013
Add timeout to ssh connections
|
On second thought, this is fine. Merging! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-vcsrepo
that referenced
this pull request
Jan 3, 2018
Add timeout to ssh connections
bastelfreak
added a commit
to bastelfreak/puppetlabs-vcsrepo
that referenced
this pull request
Apr 23, 2021
modulesync 3.0.0 & puppet-lint updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ny other remote connection issues) from blocking the Puppet run. I hardcoded it to 120 seconds which seems reasonable and should be well outside any 30 second DNS timeout pause users might see on a poorly configured system.