Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (#10440) by making all commands optional #9

Merged
merged 1 commit into from
Nov 3, 2011
Merged

Fix (#10440) by making all commands optional #9

merged 1 commit into from
Nov 3, 2011

Conversation

webfactory
Copy link

Make all commands optional. This will work around the symptoms described in http://projects.puppetlabs.com/issues/6907 (for the vcsrepo type), as the agent run will no longer fail if one of the commands is not installed.

This gives you enough time to install the necessary packages through Puppet (make sure you get the dependencies right), as the agent won't fail unless you really start accessing the repository.

@kbarber
Copy link

kbarber commented Oct 28, 2011

Hey thanks for this ... sorry for the delay in response.

Just for housekeeping and triage purposes - can you raise a ticket on this in redmine?

http://projects.puppetlabs.com/projects/modules/issues/new

Sorry about the hassle but we prefer to have the commit message align with a ticket. Also - you need to read and sign the CLA, but from memory you've submitted other things before so this may have already been done :-).

@webfactory
Copy link
Author

http://projects.puppetlabs.com/issues/10440

How can I change the commit message accordingly, or shall I just change the title of this pull req?

@kbarber
Copy link

kbarber commented Nov 2, 2011

If you do:

git commit --amend

In your branch it will let you change the title of a commit message. Then just push it back into your branch. You will probably need to force it however since you are overwriting history ... something like:

git push origin +topic_optional_commands:topic_optional_commands

Will do it. You won't need to open a new pull request, this pull request will just get updated.

@kbarber
Copy link

kbarber commented Nov 2, 2011

Oh yeah - and update the ticket or this pull request when done ... as I don't get notified when you rebase on an open pull request. Thanks mate!

This will work around the issue in http://projects.puppetlabs.com/issues/6907, as the agent run will no longer fail if one of the commands is not installed.

This gives you enough time to install the necessary packages through Puppet (make sure you get the dependencies right), as the agent won't fail unless you really start accessing the repository.
@webfactory
Copy link
Author

Done, thanks for the help!

kbarber added a commit that referenced this pull request Nov 3, 2011
Fix (#10440) by making all commands optional
@kbarber kbarber merged commit 8e16891 into puppetlabs:master Nov 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants