(gh-cat-9) Add specific data types #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsus_client is a classthat may have no external impact to Forge modules. wsus_client::setting is a typethat may have no external impact to Forge modules. This module is declared in 1 of 579 indexed public
|
Previous to this commit, the wsus_client module would fail to start unit and/or spec testing on any PR, crashing at the beginning of the process and throwing syntax errors. This commit aims to review and fix multiple syntax warnings, making sure that the module complies with syntax standards and that each parameter has an appropriate data type assigned. Note: This is backwards incompatible.
Prior to this commit, a different commit containing some syntax update was implemented. However, this update broke several test cases. This commit aims to update the unit_spec.rb test file so that its test cases keep working as intended. It also makes a few changes on top of the previous syntax update to help the test file run correctly.
chelnak
approved these changes
Jun 24, 2022
jordanbreen28
added a commit
that referenced
this pull request
Dec 13, 2022
Prior to this commit, spec tests for this module were not as strict on error messages as was hoped due to changes introduced in #181. This commit aims to reduce the chance of erroneous tests appearing as passed, by matching to more accurate and strict error messages.
jordanbreen28
added a commit
that referenced
this pull request
Dec 13, 2022
Prior to this commit, spec tests for this module were not as strict on error messages as was hoped due to changes introduced in #181. This commit aims to reduce the chance of erroneous tests appearing as passed, by matching to more accurate and strict error messages.
jordanbreen28
added a commit
that referenced
this pull request
Dec 13, 2022
Prior to this commit, spec tests for this module were not as strict on error messages as was hoped due to changes introduced in #181. This commit aims to reduce the chance of erroneous tests appearing as passed, by matching to more accurate and strict error messages.
jordanbreen28
added a commit
that referenced
this pull request
Dec 13, 2022
Prior to this commit, spec tests for this module were not as strict on error messages as was hoped due to changes introduced in #181. This commit aims to reduce the chance of erroneous tests appearing as passed, by matching to more accurate and strict error messages.
jordanbreen28
added a commit
that referenced
this pull request
Dec 14, 2022
Prior to this commit, spec tests for this module were not as strict on error messages as was hoped due to changes introduced in #181. This commit aims to reduce the chance of erroneous tests appearing as passed, by matching to more accurate and strict error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, the wsus_client module would fail to start
unit and/or spec testing on any PR, crashing at the beginning of the
process and throwing syntax errors.
This commit aims to review and fix multiple syntax warnings, making sure
that the module complies with syntax standards and that each parameter
has an appropriate data type assigned.
Note: This is backwards incompatible.