(MODULES-11418) Resuable workflows for unit tests
This commit switches the GitHub Actions workflows for unit tests over to using the reusable workflows in puppetlabs/phoenix-github-actions.
Merge pull request #42 from mhashizume/MODULES-11418/main/reusable-wo…
…rkflows (MODULES-11418) Resuable workflows for unit tests
This commit updates the commits Rake check to include commit summaries that begin with the Puppet Agent (PA) Jira project and removes references to a non-existent CONTRIBUTING.md.
(PA-5804) Update Checkout GitHub Action
The Checkout GitHub Action v3 uses Node 16, which hit end-of-life on September 11, 2023. This commit updates all instances of the Checkout Action from v3 to v4.
Merge pull request #43 from mhashizume/PA-5804/main/checkout-action
(PA-5804) Update Checkout GitHub Action
(PA-5395) Use reusable static code analysis
This commit updates the static code analysis GitHub Actions workflow from using a copy in this repository to a resuable copy in the Phoenix team centralized GitHub Actions repository. In addition, this removes the commits Rake task as it is no longer used in the reusable version of this workflow.
This commit adds a GitHub Actions workflow to export issues from GitHub into Jira.
Merge pull request #44 from mhashizume/PA-5395/main/github_issues
(PA-5395) Issues housekeeping
This commit updates this module from PDK template 2.7.1 to 3.0.1. In addition to the boilerplate changes, this commit also: - Updates the "auto release" GitHub Action to "release prep," reflecting upstream change (puppetlabs/pdk-templates@c3f57b7). - Removes the github_changelog_generator and concurrent-ruby gems, which were previously needed for the release process but are no longer necessary in newer release processes in the PDK template.
This commit addresses the following Rubocop offenses: - Performance/StringInclude - Style/ClassAndModuleChildren - Style/TernaryParentheses
Merge pull request #45 from mhashizume/PA-5963/main/concurrent-ruby
Update to PDK template 3.0.1
The assert_no_match method in Beaker was long deprecated then eventually removed altogether in voxpupuli/beaker@6282311 This commit updates assert_no_match to refute_match.
Update stdout and stderr method calls.
This commit updates Beaker tests to access stdout and stderr through a block argument.
Merge pull request #46 from mhashizume/PA-5022/main/beaker-deprecated
Update deprecated Beaker methods
This commit updates .sync.yml and Gemfile to use newer beaker dependencies: beaker 5.x beaker-abs 1.x beaker-puppet 3.x This commit also removes beaker-pe.
(PA-5781) Configure host type as AIO
Previously, when running with beaker 5 and latest beaker-puppet, tests failed
with:
cannot add defaults of type pe for host redhat7-64-1 (add_pe_defaults_on not present)
The error came from beaker-puppet when it tried to configure the host as a PE
agent[1].
The root cause is beaker defaults its options to `pe`[2]. When `beaker-puppet`
calls the `configure_type_defaults_on` method, it calls the appropriate
`add_<type>_defaults_on` method. This works when using beaker 4 as `beaker-pe`
is pulled in as a dependency and its `add_pe_defaults_on` method[3] is included
into the tests.
However, when running with beaker5, beaker-pe is not loaded, so the method is
undefined. It appears beaker-puppet_install_helper is responsible for the
whether beaker-pe is loaded or not, but only when using
beaker-puppet_install_helper 0.9.4.
Since these tests don't actually depend on PE, drop beaker-pe, require
'beaker-puppet' directly (so the install_from_build_data_url method exists) and
configure the host type directly.
[1] https://github.com/puppetlabs/beaker-puppet/blob/7175b5c1acb5cddb3a31ddcc114f09cddd3b83d0/lib/beaker-puppet/install_utils/puppet_utils.rb#L167
[2] https://github.com/voxpupuli/beaker/blob/c61ee381d3801bad70989d9b3cbf970771e6f330/lib/beaker/options/presets.rb#L139
[3] https://github.com/puppetlabs/beaker-pe/blob/3bfe913b8d57c805cc0c51ae899fff174224d5f5/lib/beaker-pe/install/pe_defaults.rb#L93
Commit originally from joshcooper/puppetlabs-cron_core@d456d2aMerge pull request #47 from AriaXLi/PA-5781/beaker5
(PA-5781) Use Beaker 5
Limit beaker-puppet to older Rubies
No version of beaker-puppet is compatible with Ruby >= 3.2 because of taint functions. Because beaker-puppet specifies that it cannot run on Ruby > 3.1 in its gemspec, when you run bundle install on newer Rubies-even when excluding the Gem group to which beaker-puppet belongs-Bundler errors. This commit updates the Gemfile to only list beaker-puppet if Ruby is less than 3.1.0.
Make Vox Rake tasks conditional
This commit updates the Rakefile to only attempt to use Vox Rake tasks if the voxpupuli-acceptance gem is installed.
Merge pull request #48 from mhashizume/PA-6049/main/release-prep
Release prep housekeeping
Merge pull request #49 from puppetlabs/release-prep
Release prep v1.2.0