(PA-3974) Increase DH key size for pcp-broker#835
Merged
ciprianbadescu merged 1 commit intoSep 6, 2021
Conversation
GabrielNagy
added a commit
to GabrielNagy/puppet-runtime
that referenced
this pull request
Sep 3, 2021
This reverts commit 94fe3e2. Removing the ciphers should no longer be needed after puppetlabs/pxp-agent#835 is merged.
GabrielNagy
added a commit
to GabrielNagy/puppet-runtime
that referenced
this pull request
Sep 3, 2021
This reverts commit 94fe3e2. Removing the ciphers should no longer be needed after puppetlabs/pxp-agent#835 is merged.
mcdonaldseanp
approved these changes
Sep 3, 2021
donoghuc
reviewed
Sep 3, 2021
donoghuc
reviewed
Sep 3, 2021
GabrielNagy
force-pushed
the
PA-3974/increase-dh-key-size
branch
from
d9ce442 to
6659854
Compare
Add the 'jdk.tls.ephemeralDHKeySize=2048' JVM option when running pcp-broker, as the default DH key size is too small for openssl 1.1.1k FIPS.
Contributor
|
Thanks so much @GabrielNagy for tracking this down! Excellent work. |
Contributor
|
Yes, thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the 'jdk.tls.ephemeralDHKeySize=2048' JVM option when running pcp-broker, as the default DH key size is too small for openssl 1.1.1k FIPS.