Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r10k requires version specification for Forge modules in Puppetfile #21

Closed
antaflos opened this issue Apr 25, 2013 · 5 comments
Closed
Milestone

Comments

@antaflos
Copy link
Contributor

As far as I understand the Puppetfile format allows specifying Forge modules without a version number. It seems r10k doesn't support that:

[R10K::Action::Environment::Deploy - INFO] Deploying environment testing

Runtime error: #<RuntimeError: Module puppetlabs/apt with args [] doesn't have an implementation. (Are you using the right arguments?)>

The Puppetfile in question:

forge "http://forge.puppetlabs.com"

mod "puppetlabs/apt"
...

Adding a version specification makes it work again:

forge "http://forge.puppetlabs.com"

mod "puppetlabs/apt", "1.1.0"
@adrienthebo
Copy link
Contributor

Strange... I could have sworn that I fixed this at some point but it looks like I didn't. Given something like `mod "foo/bar", would you say that the slash is enough to indicate that it's a Forge module? What should the default behavior if a module doesn't have any arguments?

@antaflos
Copy link
Contributor Author

antaflos commented May 2, 2013

I think the behaviour should be similar to librarian-puppet, shouldn't it? We haven't used librarian-puppet extensively but I believe the slash is enough to indicate a Forge module and without any version arguments it gets the latest available version.

@adrienthebo
Copy link
Contributor

I agree with you, and I'll update the detection to behave accordingly.

@adrienthebo
Copy link
Contributor

Merged in 9ef872c; this should be released in 1.0.0. Thanks again for the report!

@adrienthebo
Copy link
Contributor

Released in 1.0.0rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants