cli/puppetfile: add moduledir and puppetfile #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This options appear to already be handled by the action. Surfacing them at the command level so they can be used
|
@adrienthebo is anything else required from me to pose this for review? It looked like it was a wanted change as there was todo items in the code for it. I think the deprecated part was pulling this settings from env vars, but I may have misunderstood and the functionality as a whole was deprecated. |
|
@rowleyaj sorry for the delay - this looks good, and I should be able to merge this as-is and just got bogged down. With luck I'll be able to get to it shortly. Again, sorry for the delay and thanks for both the contribution and your patience! |
adrienthebo
added a commit
that referenced
this pull request
Jul 30, 2015
cli/puppetfile: add moduledir and puppetfile
|
Merged into master in 221c7df; this should be released in 2.1.0. Thanks for the contribution! |
|
Thanks @adrienthebo :) |
openstack-gerrit
pushed a commit
to openstack/puppet-openstack-integration
that referenced
this pull request
Feb 5, 2018
The PUPPETFILE and PUPPETFILE_DIR environment variables are deprecated since several releases and are superseeded by the --puppetfile and --moduledir arguments. [0] [1] This patch replaces all those occurences to future proof it when the env vars are removed. [0] http://logs.openstack.org/57/529657/2/check/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/ce6f987/job-output.txt.gz#_2017-12-21_22_52_53_499924 [1] puppetlabs/r10k#479 Change-Id: I216fe01a13e46c90bbb1455df72b25daf899c9f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options appear to already be handled by the action.
Surfacing them at the command level so they can be used