Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/ruby-pwsh
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.10.1
Choose a base ref
...
head repository: puppetlabs/ruby-pwsh
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.10.2
Choose a head ref
  • 10 commits
  • 11 files changed
  • 6 contributors

Commits on Jul 6, 2021

  1. Configuration menu
    Copy the full SHA
    a074577 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15f8f9c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Merge pull request #178 from michaeltlombardi/maint/main/enable-jea-t…

    …ests
    
    (MAINT) Enable acceptance tests for class-based resources
    david22swan authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    256d6ea View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. (GH-180) Ensure instance_key respects full uniqueness of options

    Prior to this commit, the instance_key method for the PowerShell Manager only partially
    respected the uniqueness of a possible instance; if there are any differences between
    two declarations in the path to the executable, arguments passed to the executable, or
    the debug option, the manager would treat the new instance as expected, spinning up an
    additional instance of the manager.
    
    However, it completely ignored the pipe_timeout option, meaning specifying an instance
    with a default pipe_timeout and a second instance with a pipe_timeout of 45 would
    **actually** result in the second instance declaration just reusing the existing instance
    with the default timeout, which is unwanted an unexpected behavior.
    
    This commit modifies the logic for the instance_key method slightly by making the key a
    concatenation of the path to the executable, the arguments, and the full options hash
    turned into a string.
    
    This both ensures that instance declarations with two different pipe timeouts are actually
    both spun up as separate instances *and* enables a workaround for multi-threading:
    
    Users will be able to specify an arbitrary option, such as instance_guid, which can uniquely
    identify the instance for that thread. This should help folks keep the instances separated
    and prevent weird behavior when calling the manager from multiple threads (though, of course,
    this does mean that the multi-threading still has a spinup cost for each thread).
    
    Related to/discovered in #180.
    michaeltlombardi committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    def917a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #181 from michaeltlombardi/gh-180/main/fix-instanc…

    …e_key-uniqueness
    
    (GH-180) Ensure instance_key respects full uniqueness of options
    da-ar authored Aug 16, 2021
    Configuration menu
    Copy the full SHA
    0940d89 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Merge pull request #183 from puppetlabs/release

    Mergeback 0.10.1 Release
    sanfrancrisko authored Aug 23, 2021
    Configuration menu
    Copy the full SHA
    4ce17ae View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. (GH-188) Filter current environment variables

    When Protected Event Logging and PowerShell Script Block logging are
    enabled together the SystemRoot environment variable is a requirement.
    
    If it is removed as part of the environment purge it causes the
    PowerShell process to crash, therefore breaking the pipe between Ruby
    and the remote PowerShell session.
    
    This commit fixes the issue by creating a filtered list of environment
    variables which does not include the SystemRoot environment variable.
    
    This list can then be purged safely.
    chelnak committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    10a9081 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Merge pull request #189 from puppetlabs/GH-188-fix_environment_reset

    (GH-188) Filter current environment variables
    LukasAud authored Jun 24, 2022
    Configuration menu
    Copy the full SHA
    6f1f0c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e777a1b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #190 from puppetlabs/release-prep

    (MAINT) Release prep for 0.10.2
    chelnak authored Jun 24, 2022
    Configuration menu
    Copy the full SHA
    e794b57 View commit details
    Browse the repository at this point in the history
Loading