Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/ruby-pwsh
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.5.1
Choose a base ref
...
head repository: puppetlabs/ruby-pwsh
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.6.0
Choose a head ref
  • 17 commits
  • 9 files changed
  • 6 contributors

Commits on Sep 25, 2020

  1. Merge pull request #48 from puppetlabs/release

    (MAINT) Mergeback 0.5.1 release
    david22swan authored Sep 25, 2020
    Configuration menu
    Copy the full SHA
    f9c3f8e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. (GH-55) Handle intentionally empty arrays

    Prior to this commit the DSC base provider would
    occasionally need to send an empty array as a
    defined property to Invoke-DscResource. However,
    the CIM instance on the other end may not be able
    to appropriately cast from an empty array to, say
    a [String[]] type; this would cause the run to
    fail. Furthermore, the provider did not have a way
    to distinguish between an *absent* setting and an
    *empty* one. Ruby does not treat empty arrays and
    nil as the same, even though PowerShell can/does.
    
    This commit adds a special handler for munging the
    data returned from a get invocation, ensuring that
    if a propertys value is nil AND the property was
    used for the query AND the resource expects an
    array, THEN it will set the result to the manifest
    value or an empty array.
    
    It also strongly types any empty arrays being sent
    to Invoke-DscResource, as this prevents the casting
    problem by making the array type casting  explicit
    instead of merely implicit.
    
    - Resolves #55
    michaeltlombardi committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    3e4152b View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Configuration menu
    Copy the full SHA
    6af0b85 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Configuration menu
    Copy the full SHA
    117171c View commit details
    Browse the repository at this point in the history
  2. (MAINT) Re-enable appveyor

    The move from master -> main broke CI.
    michaeltlombardi committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    6c604e3 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #56 from michaeltlombardi/gh-55/main/handle-empty-…

    …arrays
    
    (GH-55) Handle intentionally empty arrays
    RandomNoun7 authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a65f6fa View commit details
    Browse the repository at this point in the history
  4. (GH-57) Handle datetimes in dsc

    Prior to this commit the dsc_base_provider could not handle
    DateTime objects from Puppet, having no useful way to format
    them for PowerShell nor read them back from a Get result.
    
    This commit adds some minor handling to ensure that any
    datetimes are cast appropriately in the param hash and can
    be parsed by Puppet if returned.
    
    - Fixes #57
    michaeltlombardi committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    28f6838 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #58 from michaeltlombardi/gh-57/main/handle-datetime

    (GH-57) Handle datetimes in dsc
    jpogran authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    7ef1752 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. (GH-59) Refactor away from Simple Provider

    Prior to this commit the DSC Base provider inherited from
    the Resource APIs Simple Provider. This brought with it a
    limitation in the type definition, requiring all of the
    generated DSC types to have the ensure attribute. This
    led to the confusion in puppetlabs/Puppet.Dsc#72 as well
    as necessitated the filing of puppetlabs/Puppet.Dsc#74
    to improve the UX.
    
    This commit removes the dependence on the Simple Provider
    and instead copies over the code from it - namely, the
    set method - and modifies it slightly for brevity.
    
    This change sets up a few things:
    
    1. The collapse of the ensure and dsc_ensure attributes.
       Once merged, the ensure attribute becomes redundant;
       the provider no longer needs to care about it and it
       can be removed from both generation and the provider.
    2. The dropping of the simple_get_filter from puppetized
       DSC Resource type definitions. The feature is made
       redundant in this commit and no longer used.
    3. Refactoring of this provider for clarity. Now that all
       of the required code for this provider lives in this
       gem we can look to refactor some of the helpers out and
       clean things up a little.
    
    - Resolves #59
    - Unblocks puppetlabs/Puppet.Dsc#74
    michaeltlombardi committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    004d46c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Merge pull request #60 from michaeltlombardi/gh-59/main/implement-set

    (GH-59) Refactor away from Simple Provider
    pmcmaw authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    fd51a41 View commit details
    Browse the repository at this point in the history
  2. (GH-74) Remove ensure from dsc base provider

    This commit removes the special handling for the ensure keyword
    from the dsc base provider to facillitate the collapse of the
    ensure and dsc_ensure keywords.
    
    - Relates to puppetlabs/Puppet.Dsc#74
    michaeltlombardi committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    afba915 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0f2426 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #61 from michaeltlombardi/gh-74/main/remove-ensure

    (GH-74) Remove special handling for ensure in the dsc base provider
    pmcmaw authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    909652f View commit details
    Browse the repository at this point in the history
  5. (GH-81) Handle parameters

    This commit removes parameters from the return hash
    in invoke_get_method of the dsc base provider and
    also removes the redundant handling for the
    PSDSCRunAsCredential property, which is always a
    parameter.
    
    - Related to puppetlabs/Puppet.Dsc#81
    michaeltlombardi committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    b31e631 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #62 from michaeltlombardi/gh-81/main/handle-parame…

    …ters
    
    (GH-81) Handle parameters in the dsc base provider
    pmcmaw authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    815b383 View commit details
    Browse the repository at this point in the history
  7. (MAINT) Prep for 0.6.0 release

    pmcmaw committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    55a7f75 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #65 from pmcmaw/maint/release/prep-0.6.0

    (MAINT) Prep for 0.6.0 release
    michaeltlombardi authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    d2a4366 View commit details
    Browse the repository at this point in the history
Loading