(GH-105) Ensure canonicalized_cache check validates against namevar #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the safety check in the canonicalize method intended to prevent multiple executions to canonicalize the same resource compared the cached resources to the *full* resource being checked; this commit changes that check to only search for a hash containing the matching namevars. This should prevent multiple runs and bugs where mandatory parameters are dropped during an RSAPI refresh event.
RandomNoun7
approved these changes
Feb 11, 2021
michaeltlombardi
deleted the
gh-105/main/check-canonical-cache-on-namevar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the safety check in the canonicalize method intended to prevent multiple executions to canonicalize the same resource compared the cached resources to the full resource being checked; this commit changes that check to only search for a hash containing the matching namevars.
This should prevent multiple runs and bugs where mandatory parameters are dropped during an RSAPI refresh event.