(GH-144) Enable order-insensitive comparisons for DSC #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit value comparisons in the DSC Base Provider only partially worked for arrays and hashes; in PowerShell, the order of a hash or array does not matter for comparison but in Ruby hashes and arrays are order-sensitive. The same? method was meant to get around this but only worked for non-enumerable values and values which were simple arrays. This commit adds a new recursively_sort method to obviate this issue and calls it in same?
|
Test failures on Travis are due to a break in Microsoft's apt repos; see dotnet/core#6381 |
david22swan
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit value comparisons in the DSC Base Provider only partially worked for arrays and hashes; in PowerShell, the order of a hash or array does not matter for comparison but in Ruby hashes and arrays are order-sensitive.
The
same?method was meant to get around this but only worked for non-enumerable values and values which were simple arrays.This commit adds a new
recursively_sortmethod to obviate this issue and calls it insame?same?should be able to order insensitively compare deeply nested arrays and hashes #144