(GH-147) Refactor Invocation methods to use shared helper and write error logs when appropriate #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
force-pushed
the
GH-147/main/refactor-invocaton-methods
branch
9 times, most recently
from
f5b3a07
to
9aecaa3
Compare
Update the methods name in order to give greater clarity to anyone looking into the code
david22swan
force-pushed
the
GH-147/main/refactor-invocaton-methods
branch
2 times, most recently
from
fd82f41
to
85e4bc1
Compare
michaeltlombardi
changed the title
michaeltlombardi
changed the title
… method A new method `invoke_dsc_resource` has been created that handles the calling and error handling for both invocation methods
david22swan
force-pushed
the
GH-147/main/refactor-invocaton-methods
branch
from
85e4bc1
to
56108b2
Compare
michaeltlombardi
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should_to_resourcerenamed tooinvocable_resourcein order to better represent what the method does at a glance and help to ease the understanding of the module.Logic shared between
invoke_get_methodandinvoke_set_methodhas been moved into a new method,invoke_dsc_resource. Said logic has in turn been hardened so that it now throws an error and returns nill should any of the following occur: