(GH-155) Fix CIM Instance munging in invoke_get_method for DSC Base Provider
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, CIM Instances were not properly munged in invoke_get_method. The keys for CIM Instance hashes were camelcased instead of downcased and top-level CIM Instance hashes included the cim_instance_type key when only nested CIM Instances should include that key. This commit ensures that enumerables returned from DSC are appropriately munged by downcasing all hash keys and removing the cim_instance_type key from any non-nested CIM Instance properties. It replaces the camelcase_hash_keys! method with the downcase_hash_keys! method and introduces the new munge_cim_instances! method.
michaeltlombardi
changed the title
invoke_get_method for DSC Base Provider
jpogran
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, CIM Instances were not properly munged in
invoke_get_method. The keys for CIM Instance hashes were camelCased instead of downcased and top-level CIM Instance hashes included thecim_instance_typekey when only nested CIM Instances should include that key.This PR ensures that enumerables returned from DSC are appropriately munged by downcasing all hash keys and removing the
cim_instance_typekey from any non-nested CIM Instance properties.It replaces the
camelcase_hash_keys!method with thedowncase_hash_keys!method and introduces the newmunge_cim_instances!method.