(GH-154) Ensure values returned from invoke_get_method are recursively sorted in the DSC Base Provider to reduce canonicalization warnings.
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the values returned from DSC via invoke_get_method were left in the order returned by PowerShell. This caused issues during comparisons during canonicalization due to the Ruby (and therefore Puppet) caring about the ordering of arrays and hashes and PowerShell not. This commit therefore recursively sorts the result before handing it back, ensuring that canonicalized manifest values and values returned from get are both sorted appropriately, ending the errors and mismatches.
david22swan
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the values returned from DSC via
invoke_get_methodwere left in the order returned by PowerShell. This caused issues during comparisons during canonicalization due to the Ruby (and therefore Puppet) caring about the ordering of arrays and hashes and PowerShell not.This PR therefore recursively sorts the result before handing it back, ensuring that canonicalized manifest values and values returned from get are both sorted appropriately, ending the errors and mismatches.
Getfails #154