Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-10389) Add puppet feature for dependent modules to leverage #20

Merged
merged 1 commit into from
Jan 13, 2020
Merged

(MODULES-10389) Add puppet feature for dependent modules to leverage #20

merged 1 commit into from
Jan 13, 2020

Conversation

sanfrancrisko
Copy link
Contributor

Description

This is a hotfix to resolve an issue customers are seeing after the v.3.0.0 release of the puppetlabs-powershell module. Adding a pwshlib feature will ensure that the powershell provider is only loaded if the functionality is detected. On Linux systems, this should prevent Puppet from throwing the following error:

Error: Could not autoload puppet/provider/exec/powershell: Could not load the "ruby-pwsh" library; is the dependency module puppetlabs-pwshlib installed in this environment?
Error: Could not autoload puppet/type/exec: Could not autoload puppet/provider/exec/powershell: Could not load the "ruby-pwsh" library; is the dependency module puppetlabs-pwshlib installed in this environment?
Error: Could not run: Could not autoload puppet/type/exec: Could not autoload puppet/provider/exec/powershell: Could not load the "ruby-pwsh" library; is the dependency module puppetlabs-pwshlib installed in this environment?

See MODULES-10389 for more details

@sanfrancrisko sanfrancrisko added the bug Something isn't working label Jan 9, 2020
@sanfrancrisko sanfrancrisko requested a review from a team as a code owner January 9, 2020 11:58
(MODULES-10389) Only load pwshlib if functionality present
fcc76f3 
This is a hotfix to resolve an issue customers are seeing after the v.3.0.0 release of the puppetlabs-powershell module. Adding a pwshlib feature will ensure that the powershell provider is only loaded if the functionality is detected. On Linux systems, this should prevent Puppet from throwing an error when it cannot load ruby-pwsh
@michaeltlombardi
Copy link
Contributor

👍

@sheenaajay sheenaajay merged commit 5eb9a75 into puppetlabs:master Jan 13, 2020
@michaeltlombardi michaeltlombardi added feature and removed bug Something isn't working labels Jan 14, 2020
@michaeltlombardi michaeltlombardi changed the title (MODULES-10389) Only load pwshlib if functionality present (MODULES-10389) Add puppet feature for dependent modules to leverage Jan 14, 2020
@sanfrancrisko sanfrancrisko deleted the MODULES-10389 branch January 20, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@DavidS DavidS Awaiting requested review from DavidS

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanfrancrisko @michaeltlombardi @david22swan @sheenaajay