Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) - add retries on failed dsc invocation #282

Merged
merged 1 commit into from Jan 31, 2024

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Jan 29, 2024

Summary

Before, if the dsc_base_provider encountered a collision of two Invoke-DscResource runs it would error out. Now, we will retry the execution up to a sensible number of times (up to max of 5 times in 5 mins to allow larger configurations to fully apply) before attempting to run again.

If 5 minutes surpass and we are still experiencing collisions, error out as before.

Additional Context

Marked as a feature and not bugfix as this is not a bug with ruby-pwsh, and is a limitation of DSC. So, we can only try negate this as best as we can on the puppet side.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36ed427) 91.55% compared to head (3e97cbf) 91.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   91.55%   91.83%   +0.27%     
==========================================
  Files           6        6              
  Lines         675      698      +23     
==========================================
+ Hits          618      641      +23     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 force-pushed the bug-retry_on_invokedsc_collision branch 24 times, most recently from dd84c94 to 9450241 Compare January 30, 2024 18:15
@jordanbreen28 jordanbreen28 changed the title (bug) - add retries on failed dsc invocation (feat) - add retries on failed dsc invocation Jan 30, 2024
@jordanbreen28 jordanbreen28 force-pushed the bug-retry_on_invokedsc_collision branch from 9450241 to 5a8a938 Compare January 31, 2024 09:21
@jordanbreen28 jordanbreen28 force-pushed the bug-retry_on_invokedsc_collision branch 6 times, most recently from 6fd5a5f to bee222a Compare January 31, 2024 11:20
@jordanbreen28 jordanbreen28 marked this pull request as ready for review January 31, 2024 11:21
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner January 31, 2024 11:21
@jordanbreen28 jordanbreen28 marked this pull request as draft January 31, 2024 11:28
@jordanbreen28 jordanbreen28 force-pushed the bug-retry_on_invokedsc_collision branch 3 times, most recently from 28d6536 to 23d4d9b Compare January 31, 2024 13:52
@jordanbreen28 jordanbreen28 marked this pull request as ready for review January 31, 2024 13:58
@jordanbreen28 jordanbreen28 force-pushed the bug-retry_on_invokedsc_collision branch 3 times, most recently from 8478eb0 to fd37db6 Compare January 31, 2024 14:29
@jordanbreen28 jordanbreen28 force-pushed the bug-retry_on_invokedsc_collision branch from fd37db6 to 3e97cbf Compare January 31, 2024 14:37
@david22swan david22swan merged commit a74bd25 into main Jan 31, 2024
8 checks passed
@david22swan david22swan deleted the bug-retry_on_invokedsc_collision branch January 31, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants