Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ruby versions older than 2.3 function correctly #30

Merged
merged 2 commits into from Feb 13, 2020

Conversation

@binford2k
Copy link
Member

binford2k commented Feb 12, 2020

Fixes #28

Fixes #1
@binford2k binford2k requested a review from puppetlabs/modules as a code owner Feb 12, 2020
lib/pwsh.rb Outdated Show resolved Hide resolved
Co-Authored-By: Michael T Lombardi (He/Him) <michael.t.lombardi@outlook.com>
@michaeltlombardi michaeltlombardi changed the title Fix support for older ruby Ensure ruby versions older than 2.3 function correctly Feb 13, 2020
@michaeltlombardi michaeltlombardi merged commit a1b1e59 into puppetlabs:master Feb 13, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@michaeltlombardi michaeltlombardi added bugfix and removed bug labels Feb 13, 2020
@@ -54,7 +54,7 @@ def self.instance(cmd, args, options = {})
if manager.nil? || !manager.alive?
# ignore any errors trying to tear down this unusable instance
begin
manager&.exit
manager.exit if defined?(manager)

This comment has been minimized.

Copy link
@glennsarti

glennsarti Feb 13, 2020

Contributor

This should really be manager.exit unless manager.nil?

defined?(manager) will still be true it manager == nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.