Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - Fix incorrect test for file_path #335

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Aug 21, 2024

Summary

Fixes a unit test wrongly configured in #334.
The invalid_directories? method should return true if passed a path that exists, but is a file. As we did not mock File.exists? the incorrect test went unnoticed.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (5603c13) to head (463a1ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files           6        6           
  Lines         720      720           
=======================================
  Hits          663      663           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review August 21, 2024 08:34
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner August 21, 2024 08:34
@jordanbreen28 jordanbreen28 force-pushed the cat-1991-skip_missing_dir_check branch from 84cd99b to 463a1ba Compare August 21, 2024 08:38
@jordanbreen28 jordanbreen28 merged commit 351b383 into main Aug 21, 2024
8 checks passed
@jordanbreen28 jordanbreen28 deleted the cat-1991-skip_missing_dir_check branch August 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants