(IAC-1045) Add the DSC base Puppet provider to pwshlib #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the code for the base provider of the new puppetized DSC modules was vendored into each module; this meant that if the provider ever needs to be updated, *every* prior release of the puppetized module would need to be built again and pushed with an incremented number. Moving the base provider to the pwshlib Puppet module (which is this ruby library packaged as a Puppet module) means that the provider can be updated separately from the PowerShell builder code and does not require rebuilding puppetized modules, only updating the reference pin for pwshlib. This also makes testing the provider easier as it lives in a ruby library now instead of in a PowerShell module.
|
Updated with scaffolding and minimal buildout of the unit tests; as this functionality is thoroughly covered by acceptance tests in puppetlabs/PuppetDscBuilder, I think we're okay to merge with this pending suite to move forward with MODULES-1045, enabling customer feedback. See puppetlabs/Puppet.Dsc#44 for the passing acceptance tests using this commit hash as the fixture for the tests. |
michaeltlombardi
changed the title
sheenaajay
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the code for the base provider of the new
puppetized DSC modules was vendored into each module; this
meant that if the provider ever needs to be updated, every
prior release of the puppetized module would need to be built
again and pushed with an incremented number.
Moving the base provider to the pwshlib Puppet module (which
is this ruby library packaged as a Puppet module) means that
the provider can be updated separately from the PowerShell
builder code and does not require rebuilding puppetized modules,
only updating the reference pin for pwshlib.
This also makes testing the provider easier as it lives in a
ruby library now instead of in a PowerShell module.