(MAINT) Ensure dsc provider finds dsc resources during agent run #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the dsc_base_provider used the LOAD_PATH to find the appropriate Puppet module and retrieve the DSC resources from it; this does not work in a puppet agent run, because the resources are placed flatly on disc in lib/puppet and lib/puppet_x, not per-module as with a puppet apply run. This commit adds a handler to fall back on relative paths for discovery in the case where the module cannot be found in the LOAD_PATH.
|
Validated that this change is functional with @moedes via Puppet agent runs; we should look to fast-track a release with this bugfix in place. |
binford2k
approved these changes
Sep 24, 2020
michaeltlombardi
deleted the
maint/main/make-base-provider-work-with-agent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the dsc_base_provider used the LOAD_PATH
to find the appropriate Puppet module and retrieve the DSC
resources from it; this does not work in a puppet agent run,
because the resources are placed flatly on disc in lib/puppet
and lib/puppet_x, not per-module as with a puppet apply run.
This commit adds a handler to fall back on relative paths for
discovery in the case where the module cannot be found in the
LOAD_PATH.