(GH-59) Refactor away from Simple Provider #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the DSC Base provider inherited from the Resource APIs Simple Provider. This brought with it a limitation in the type definition, requiring all of the generated DSC types to have the ensure attribute. This led to the confusion in puppetlabs/Puppet.Dsc#72 as well as necessitated the filing of puppetlabs/Puppet.Dsc#74 to improve the UX. This commit removes the dependence on the Simple Provider and instead copies over the code from it - namely, the set method - and modifies it slightly for brevity. This change sets up a few things: 1. The collapse of the ensure and dsc_ensure attributes. Once merged, the ensure attribute becomes redundant; the provider no longer needs to care about it and it can be removed from both generation and the provider. 2. The dropping of the simple_get_filter from puppetized DSC Resource type definitions. The feature is made redundant in this commit and no longer used. 3. Refactoring of this provider for clarity. Now that all of the required code for this provider lives in this gem we can look to refactor some of the helpers out and clean things up a little. - Resolves #59 - Unblocks puppetlabs/Puppet.Dsc#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the DSC Base provider inherited from the Resource APIs Simple Provider. This brought with it a limitation in the type definition, requiring all of the generated DSC types to have the ensure attribute. This led to the confusion in puppetlabs/Puppet.Dsc#72 as well as necessitated the filing of puppetlabs/Puppet.Dsc#74 to improve the UX.
This commit removes the dependence on the Simple Provider and instead copies over the code from it - namely, the set method - and modifies it slightly for brevity.
This change sets up a few things:
ensureanddsc_ensureattributes Puppet.Dsc#74