Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-81) Handle parameters in the dsc base provider #62

Merged
merged 1 commit into from
Nov 24, 2020
Merged

(GH-81) Handle parameters in the dsc base provider #62

merged 1 commit into from
Nov 24, 2020

Conversation

michaeltlombardi
Copy link
Contributor

This PR removes parameters from the return hash in invoke_get_method of the dsc base provider and also removes the redundant handling for the PSDSCRunAsCredential property, which is always a parameter.

@michaeltlombardi michaeltlombardi added the enhancement New feature or request label Nov 24, 2020
@michaeltlombardi
Copy link
Contributor Author

Merging this should rebased after #61 and #62 are merged, as it is based on them.

@michaeltlombardi michaeltlombardi mentioned this pull request Nov 24, 2020
Merged
@michaeltlombardi
(GH-81) Handle parameters
b31e631 
This commit removes parameters from the return hash
in invoke_get_method of the dsc base provider and
also removes the redundant handling for the
PSDSCRunAsCredential property, which is always a
parameter.

- Related to puppetlabs/Puppet.Dsc#81
@michaeltlombardi michaeltlombardi marked this pull request as ready for review November 24, 2020 17:15
@michaeltlombardi michaeltlombardi requested a review from a team as a code owner November 24, 2020 17:15
pmcmaw
pmcmaw approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@pmcmaw pmcmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pmcmaw pmcmaw merged commit 815b383 into puppetlabs:main Nov 24, 2020
@michaeltlombardi michaeltlombardi deleted the gh-81/main/handle-parameters branch February 2, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcmaw pmcmaw pmcmaw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeltlombardi @pmcmaw