(MAINT) Ensure parameters are canonicalized #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters are never returned from the get method, which prevented them from being included in the canonicalized resource hash passed to the set method. This commit re-adds them to the canonicalized hash.
RandomNoun7
approved these changes
Dec 9, 2020
michaeltlombardi
deleted the
maint/main/fix-parameter-canonicalization
branch
pmcmaw
added a commit
to pmcmaw/ruby-pwsh
that referenced
this pull request
Jan 19, 2021
pmcmaw
added a commit
to pmcmaw/ruby-pwsh
that referenced
this pull request
Jan 19, 2021
adrianiurca
added a commit
that referenced
this pull request
Jan 20, 2021
(GH-75) Including module name in vendored module path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters are never returned from the get method,
which prevented them from being included in the
canonicalized resource hash passed to the set method.
This commit re-adds them to the canonicalized hash.