(GH-75) Including module name in vendored module path #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcmaw
force-pushed
the
GH-75/main/installable_side_by_side
branch
from
29953ea
to
66975ab
Compare
michaeltlombardi
approved these changes
Jan 20, 2021
Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@outlook.com>
adrianiurca
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required for #puppetlabs/Puppet.Dsc#115
Currently
vendored_modules_pathis set topuppet_x/dsc_resourcesby adding this change thevendored_modules_pathwill be set topuppet_x/<modulename>/dsc_resources.This provides the capability to install PowerShell module dependencies side by side.
This PR handlles the old method, eg
puppet_x/dsc_resources, the new method, egpuppet_x/<modulename>/dsc_resourcesand also the case that something else happens and thevendored_modules_pathis not set.Note: This PR needs to be merged before #puppetlabs/Puppet.Dsc#115