Make root module path use puppetized module name #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the `root_module_path` in the `should_to_resource` method of the `dsc_base_provider` downcased the PowerShell module name; this would fail to discover the resources for modules like `7Zip` and `xHyper-V` which are Puppetized as `a7zip` and `xhyper_v` respectively. This commit uses the `puppetize_name` method to ensure the PowerShell module name is appropriately munged.
pmcmaw
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the
root_module_pathin theshould_to_resourcemethod of thedsc_base_providerdowncased the PowerShell module name; this would fail to discover the resources for modules like7ZipandxHyper-Vwhich are Puppetized asa7zipandxhyper_vrespectively.This commit uses the
puppetize_namemethod to ensure the PowerShell module name is appropriately munged.