(MAINT) Minor fixes to CIM instance handling #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSCredentials are handled specially from other CIM instances and should not be parsed twice for the DSC invocation script; the CIM instance parsing is redundant.
Prior to this commit the variables for credentials and cim instances were instantiated prior to the definition of the block for that credential or instance; this caused the variable interpolation step to replace the value definition with a self-referencing variable which would always be null, and thus fail to correctly instantiate. This commit moves the code for variable instantiation to *after* the credential or CIM instance is created, meaning only subsequent calls will reference the variable.
sanfrancrisko
changed the title
sanfrancrisko
approved these changes
Jan 25, 2021
sanfrancrisko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits prevent duplicate instantiation of Credentials and move the logic for variable instantiation to after the values are first used in a declaration.