(MAINT) Correctly canonicalize enumerable values in dsc #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the comparison in the DSC base provider for values on the node vs values in the manifest was a simple equals check; this works for non-enumerables and for enumerables *so long as* the enumerables are in the same order. This commit corrects the check to sort the enumerables so that the comparison is done purely on the values, not the order, as PowerShell does not care about the order of items in a hash or array.
pmcmaw
approved these changes
Feb 1, 2021
michaeltlombardi
deleted the
maint/main/fix-enumerable-canonicalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the comparison in the DSC base provider for values on the node vs values in the manifest was a simple equals check; this works for non-enumerables and for enumerables so long as the enumerables are in the same order.
This commit corrects the check to sort the enumerables so that the comparison is done purely on the values, not the order, as PowerShell does not care about the order of items in a hash or array.