(GH-97) Memoize class variables in initialize #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit calling initialize for the dsc base provider would always set the class variables for cached_canonicalized_resource, cached_query_results, and logon_failures to empty arrays; when running with 2 or more resources of a different type, this would cause the provider to reset these values to the empty arrays, thus wiping out these caches, especially the cache for canonicalized resources, which is filled *before* the rest of the Puppet run. This commit updates the initialize method to instead memoize those caches, only setting them to empty arrays if they do not already exist. This way, canonicalized resources from multiple types are not mysteriously removed from the cache.
sanfrancrisko
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR calling initialize for the dsc base provider would always set the class variables for cached_canonicalized_resource, cached_query_results, and logon_failures to empty arrays; when running with 2 or more resources of a different type, this would cause the provider to reset these values to the empty arrays, thus wiping out these caches, especially the cache for canonicalized resources, which is filled before the rest of the Puppet run.
This commit updates the initialize method to instead memoize those caches, only setting them to empty arrays if they do not already exist. This way, canonicalized resources from multiple types are not mysteriously removed from the cache.