Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Only center slide after images have loaded #275
I'm not able to replicate this. I even set my network to simulate a terrible link and watch an image take four seconds to progressively render, and it was still centered. Can you share more details about what would be causing what you see? Are you using very large images that don't fit on-screen?
I don't see side effects in this code, so I may merge it anyway, but I'd like to believe that we're solving a real problem here.
I have the presentation on Heroku, here is slide 5: https://software-libera-tutti.herokuapp.com/#5
I've switch the Heroku deploy back to HEAD and I see the image cut off.
Locally, I get the same result against HEAD. If I check what's happening in showoff.js, I can see that the page height is being calculated before the image has loaded.
If I use my branch, page height is calculated after the image has loaded. As a result, the title appears higher on the page and the whole image is visible.