Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tasks that are for EOL PE (SUP-2431) #101

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

MartyEwings
Copy link
Collaborator

Prior to this commit there where tasks in the bundle for EOL versions. These have been removed

delete mode 100644 tasks/st0244_disable_mco_logrotate.json
delete mode 100644 tasks/st0244_disable_mco_logrotate.sh
delete mode 100644 tasks/st0299_regen_master_cert.json
delete mode 100644 tasks/st0299_regen_master_cert.sh

This commit also has some house keeping on the readme, moving the task descriptions to REFERENCE.MD for puppet-strings compatibility

Copy link

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you possibly add a tag just prior to the delete of these tasks and then also some sort of FYI reference in the README to allow users to easily look back at the old tasks if needed.

@MartyEwings
Copy link
Collaborator Author

@gavindidrichsen good call, but hte label thats been applied "backwards-incompatible" will generate a release log and a major version indicating backwards incompatibility the next time we run the release automation, so we don't need to manually do things like that anymore

@gavindidrichsen
Copy link

...so we don't need to manually do things like that anymore

Nice!

@MartyEwings
Copy link
Collaborator Author

waiting on corresponding article removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants